chore: pull Releaser keys from keyring instead of README - #2607
Open
nschonni wants to merge 1 commit into
Open
Conversation
12 tasks
Contributor
|
I don't really see the point, this does not change the fact that building our docker images depend on the external key servers. |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@aduh95 my thinking is, that pulling from the keyring rather than scrapping the Markdown is a better approach. It also moves from a repo that can be changed by any collaborator to one owned by the releasers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Doesn't replace the way the keys are embedded in the Dockerfiles, but use the newer keyring file to read the fingerprints.
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist