chore: add check for baseuri reachability in update.sh script - #2601
Open
MikeMcC399 wants to merge 1 commit into
Open
chore: add check for baseuri reachability in update.sh script#2601MikeMcC399 wants to merge 1 commit into
MikeMcC399 wants to merge 1 commit into
Conversation
Exit fatally after 15 seconds if not reachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a check to the update.sh script for the reachability of the
baseuriserver defined in the config file, waiting 15 seconds.Output a clear and short error message then exit fatally.
Motivation and Context
If the website defined in
docker-node/config
Line 1 in 85b7a1a
./update.shmay hang indefinitely or output multiple error messages before failing.The scripts are written such that there can be a
configfile in each release line directory, although that is not used, so theoretically there can be multiplebaseuridefinitions. In later script rework exercises, such as needed for Alpine Tier 2 and Node 27, we may check if we need this flexibility, or if it could be simplified.As far as https://nodejs.org/dist is concerned, there is one location for all release lines.
Testing Details
On Ubuntu 24.04.4 LTS
Test logs
Unreachable port
Non-running server
Types of changes
Checklist