Skip to content

fix: Drop ppc64le from Node 22 Alpine builds#2130

Merged
nschonni merged 1 commit intonodejs:mainfrom
nschonni:node-22-apline-drop-ppc64le
Aug 19, 2024
Merged

fix: Drop ppc64le from Node 22 Alpine builds#2130
nschonni merged 1 commit intonodejs:mainfrom
nschonni:node-22-apline-drop-ppc64le

Conversation

@nschonni
Copy link
Copy Markdown
Member

Has not worked since 22 was released.

Closes #2107

Description

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni
Copy link
Copy Markdown
Member Author

@tianon I think this will address parts the other PR

@nschonni nschonni requested a review from a team August 19, 2024 18:19
Copy link
Copy Markdown
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, this is removing from 20, not 22 😅

Has not worked since 22 was released.

Closes nodejs#2107
@nschonni nschonni force-pushed the node-22-apline-drop-ppc64le branch from 8486438 to 07b487b Compare August 19, 2024 19:01
@nschonni nschonni requested a review from tianon August 19, 2024 19:01
@nschonni
Copy link
Copy Markdown
Member Author

Doh, this is removing from 20, not 22 😅

Good catch, I had the 22 tree collapsed in VScode 🤦

@nschonni nschonni merged commit 5cbb3b2 into nodejs:main Aug 19, 2024
@nschonni nschonni deleted the node-22-apline-drop-ppc64le branch August 19, 2024 20:05
@sxa sxa mentioned this pull request Apr 15, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:22-alpine images miss ppc64le arch

2 participants