feat: use range from devEngines when no packageManager is set - #892
Open
aduh95 wants to merge 2 commits into
Open
feat: use range from devEngines when no packageManager is set#892aduh95 wants to merge 2 commits into
devEngines when no packageManager is set#892aduh95 wants to merge 2 commits into
Conversation
Using Corepack without setting a `packageManager` is not recommended, but given that no errors is thrown when no `devEngines` is set, the behavior should be the same when one is set to a parsable range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Corepack without setting a
packageManageris not recommended, but given that no errors is thrown when nodevEnginesis set, the behavior should be the same when one is set to a parsable range.With this PR, specifying a range in
devEngines.packageManageris treated the same as specifying it on the CLI.