Skip to content

feat: use the regitry url of npm by default #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanminkian wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: use the regitry url of npm by default #656

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d29d556
feat: COREPACK_NPM_REGISTRY defaults to the regitry of npm
zanminkian Apr 10, 2025
1435643
test: fix testing error
zanminkian Apr 14, 2025
b6b489a
test: add more test
zanminkian Apr 14, 2025
80ce9a0
style: format
zanminkian Apr 14, 2025
8c07427
chore: upgrade deps
zanminkian Apr 16, 2025
26b216d
Merge branch 'main' into feat/registry_follow_npm
zanminkian May 18, 2025
cdfa08e
Merge branch 'main' into feat/registry_follow_npm
zanminkian Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix testing error
  • Loading branch information
@zanminkian
zanminkian committed Apr 14, 2025
commit 1435643a31062c3a85a68cb37b90d49a7561a007
7 changes: 6 additions & 1 deletion tests/npmRegistryUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe(`npm registry utils fetchAsJson`, () => {
});

it(`loads from DEFAULT_NPM_REGISTRY_URL by default`, async () => {
process.env.npm_config_registry = `https://registry.npmjs.org`;
await fetchAsJson(`package-name`);

expect(httpFetchAsJson).toBeCalled();
Expand All @@ -38,6 +39,7 @@ describe(`npm registry utils fetchAsJson`, () => {
it(`adds authorization header with bearer token if COREPACK_NPM_TOKEN is set`, async () => {
// `process.env` is reset after each tests in setupTests.js.
process.env.COREPACK_NPM_TOKEN = `foo`;
process.env.npm_config_registry = `https://registry.npmjs.org`;

await fetchAsJson(`package-name`);

Expand All @@ -53,6 +55,7 @@ describe(`npm registry utils fetchAsJson`, () => {
process.env.COREPACK_NPM_TOKEN = `foo`;
process.env.COREPACK_NPM_USERNAME = `bar`;
process.env.COREPACK_NPM_PASSWORD = `foobar`;
process.env.npm_config_registry = `https://registry.npmjs.org`;

await fetchAsJson(`package-name`);

Expand All @@ -68,6 +71,7 @@ describe(`npm registry utils fetchAsJson`, () => {
// `process.env` is reset after each tests in setupTests.js.
process.env.COREPACK_NPM_USERNAME = `foo`;
process.env.COREPACK_NPM_PASSWORD = `bar`;
process.env.npm_config_registry = `https://registry.npmjs.org`;

const encodedCreds = Buffer.from(`${process.env.COREPACK_NPM_USERNAME}:${process.env.COREPACK_NPM_PASSWORD}`, `utf8`).toString(`base64`);

Expand All @@ -80,9 +84,10 @@ describe(`npm registry utils fetchAsJson`, () => {
}});
});

it(`does not add authorization header if COREPACK_NPM_USERNAME is set and COREPACK_NPM_PASSWORD is not.`, async () => {
it(`does not add authorization header if COREPACK_NPM_USERNAME is set and COREPACK_NPM_PASSWORD is not`, async () => {
// `process.env` is reset after each tests in setupTests.js.
process.env.COREPACK_NPM_USERNAME = `foo`;
process.env.npm_config_registry = `https://registry.npmjs.org`;

await fetchAsJson(`package-name`);

Expand Down