Skip to content

feat!: prompt user before downloading software #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Jan 30, 2024
+31 −3
Merged

feat!: prompt user before downloading software #360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8396aed
feat: log network activity by default
aduh95 Jan 23, 2024
6566cd4
change to stderr, ask for explicit consent
aduh95 Jan 25, 2024
e38f1dd
fixup! change to stderr, ask for explicit consent
aduh95 Jan 26, 2024
859f34e
`COREPACK_ENABLE_DOWNLOAD_PROMPT`
aduh95 Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: log network activity by default
  • Loading branch information
@aduh95
aduh95 committed Jan 23, 2024
commit 8396aed10c5ff3cd9472de61cc640658df77f607
2 changes: 2 additions & 0 deletions sources/httpUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export async function fetchUrlStream(url: string, options: RequestOptions = {})

const proxyAgent = new ProxyAgent();

console.log(`Corepack: Fetching ${url}...`);

return new Promise<IncomingMessage>((resolve, reject) => {
const createRequest = (url: string) => {
const request: ClientRequest = https.get(url, {...options, agent: proxyAgent}, response => {
Expand Down