Skip to content

lookup: unskip s390 from babel - #1177

Open
abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-babel
Open

lookup: unskip s390 from babel#1177
abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-babel

Conversation

@abhayagarwal-dev

@abhayagarwal-dev abhayagarwal-dev commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes s390 from the skip list for @babel/core. Babel was initially skipped on aix, ppc, s390, and win32 but it is now passing on rhel9-s390x in Jenkins CI
https://ci.nodejs.org/job/citgm-smoker-pipeline/299/

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (3b60eb7) to head (c9ad5d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

MikeMcC399 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Please note also the open issue #1137

@abhayagarwal-dev

abhayagarwal-dev commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Please note also the open issue #1137

Thanks for the pointer to the existing issue . This PR only removes s390 from the skip list, which is confirmed passing on rhel9-s390x in Jenkins CI. The remaining platforms (aix, ppc, win32) stay skipped.

@abhayagarwal-dev
abhayagarwal-dev marked this pull request as ready for review October 7, 2026 07:04
sxa
sxa approved these changes Oct 7, 2026
View reviewed changes

@sxa sxa left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that it seems to have run significantly fewer tests on s390x than on x64:

Test Suites: 276 passed, 276 total
 Tests:       18 skipped, 36895 passed, 36913 total
 Snapshots:   279 passed, 279 total
 Time:        33.02 s

vs

Test Suites: 251 failed, 25 passed, 276 total
 Tests:       1 failed, 2 skipped, 2524 passed, 2527 total
 Snapshots:   153 passed, 153 total
 Time:        12.887 s

so maybe it just didn't run the same tests (unless it just stopped ont he first failure). But since it's passing here (and on pLinux by the look of it) I'm +1 to unskipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxa sxa sxa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhayagarwal-dev @codecov-commenter @MikeMcC399 @sxa