Repository navigation
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Member
Author
|
I'm fairly certain this won't be a problem, but if it is then we can analyse those problems if and when they show up, therefore moving this out of draft. |
sxa
marked this pull request as ready for review
November 3, 2026 17:08
richardlau
approved these changes
Nov 3, 2026
richardlau
reviewed
Nov 3, 2026
| echo $GIT_AUTHOR_NAME | ||
|
|
||
| git rebase --abort || true | ||
| pwd |
Member
There was a problem hiding this comment.
I'm not sure this is strictly needed as the script ought to be being run from the workspace directory, which Jenkins outputs in the job logs.
Member
Author
There was a problem hiding this comment.
Yeah I just didn't take the debug out when I moved it out of draft - sorted.
I was slightly tempted to leave the ls .git in just to show what was in there in case the check is invalid but given it seems incredibly infrequent that it has to do anything I've left it out.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
richardlau
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for now as this still has debug in it while it undergoes some testing but a potential solution for rogue entries in the reliability reports if this is considered the preferred solution.
Fixes nodejs/reliability#1711