Skip to content

Make index methods async #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 6 commits into from
Apr 11, 2016
Merged

Make index methods async #971

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cd6320
Make index methods async
Mar 26, 2016
4c8f601
First round of test fixes
Mar 27, 2016
367e053
Fix "commit on head on empty repo with createCommitOnHead" test
Apr 8, 2016
e958562
Fix some formatting
Apr 8, 2016
615ef49
Fix staging tests
Apr 8, 2016
a0fb5d4
Sorted things in `descriptor.json` alphabetically
Apr 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix staging tests 
Writing an index to disk is now async and no longer returns it's result code. Instead of checking for `0` we can just handle the error callback/rejected promise case.
  • Loading branch information
John Haley committed Apr 8, 2016
commit 615ef49f95eaa4ea81434c1d504e55aa9b3fd662
3 changes: 1 addition & 2 deletions test/tests/stage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ describe("Stage", function() {
});
return test.repository.stageLines(fileName, linesToStage, !staging);
})
.then(function(stageResult) {
assert.equal(stageResult, 0);
.then(function() {
return test.repository.refreshIndex();
})
.then(function(reloadedIndex) {
Expand Down