Fix symbolic reference handling in getReferences#496
Merged
johnhaley81 merged 1 commit intonodegit:masterfrom Mar 20, 2015
Merged
Fix symbolic reference handling in getReferences#496johnhaley81 merged 1 commit intonodegit:masterfrom
johnhaley81 merged 1 commit intonodegit:masterfrom
Conversation
0cec4c4 to
10f4a7d
Compare
lib/repository.js
Outdated
Member
There was a problem hiding this comment.
Do we need a typeof check here? That's really only necessary if the variable is possibly undeclared. Simply do !callback or callback == null.
Contributor
Author
There was a problem hiding this comment.
Alright, I have updated to just use !callback.
Member
There was a problem hiding this comment.
Awesome, I'm being picky here as someone could pass a falsy value that isn't undefined and that would break your check.
Contributor
Author
There was a problem hiding this comment.
No problem! You have every right to be picky. 😉
10f4a7d to
f3d0812
Compare
Collaborator
|
👍 looks good. I'm going to merge this. |
johnhaley81
added a commit
that referenced
this pull request
Mar 20, 2015
Fix symbolic reference handling in getReferences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also updated the example in
general.jsso that it would return symbolic references as expected.