Skip to content

Template proto functions #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxkorp merged 6 commits into from
Mar 3, 2015
Merged

Template proto functions #458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed903e5
works now when loading via nodegit, direct requires (eg require../clo…
maxkorp Mar 3, 2015
9d4777b
statusfile is not a function? and reset.reset not promisifying
maxkorp Mar 3, 2015
78ea4b7
fix statusfile
maxkorp Mar 3, 2015
37b3b90
remove module.exports and move stuff around A LOT
maxkorp Mar 3, 2015
dcebe44
dont swallow error in remote tests
maxkorp Mar 3, 2015
1906fea
remove unneeded locals
maxkorp Mar 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
works now when loading via nodegit, direct requires (eg require../clo… 
…ne) broken
  • Loading branch information
@maxkorp
maxkorp committed Mar 3, 2015
commit ed903e50e57a6c38224caa08d0d92ff119b19322
3 changes: 3 additions & 0 deletions generate/scripts/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ var Helpers = {
}
}).value();

if ("git_" + typeDef.typeName == fnDef.cFunctionName) {
fnDef.useAsOnRootProto = true;
}
_.merge(fnDef, _.omit(fnOverrides, "args", "return"));
},

Expand Down
23 changes: 23 additions & 0 deletions generate/templates/templates/nodegit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,29 @@ var importExtension = function(name) {
//must go last!
require("./enums");

/* jshint ignore:start */
{% each . as idef %}
{% if idef.type != "enum" %}
{% each idef.functions as fn %}

{% if fn.useAsOnRootProto %}
// Inherit directly from the original {{idef.jsClassName}} object.
_{{ idef.jsClassName }}.{{ fn.jsFunctionName }}.__proto__ =
_{{ idef.jsClassName }};

// Ensure we're using the correct prototype.
_{{ idef.jsClassName }}.{{ fn.jsFunctionName }}.prototype =
_{{ idef.jsClassName }}.prototype;

// Assign the function as the root
rawApi.{{idef.jsClassName}} =
_{{ idef.jsClassName }}.{{ fn.jsFunctionName }};
{% endif %}
{% endeach %}
{% endif %}
{% endeach %}
/* jshint ignore:end */

// Wrap asynchronous methods to return promises.
promisify(exports);

Expand Down