Skip to content

Fix callbacks with just return value and single payload #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 11 commits into from
Feb 24, 2015
Merged

Fix callbacks with just return value and single payload #416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2aff3c0
Fix callbacks with just return value
Feb 20, 2015
deeb885
Normalize returns for callbacks
Feb 20, 2015
0a7ac52
Force functions with callbacks to be async
Feb 20, 2015
530290d
Handle global payloads in functions
Feb 20, 2015
e954ae5
Fix promises not being returned in index test
Feb 23, 2015
67c6eb2
Fix git_strarray when an actual array is passed in
Feb 23, 2015
0744320
Cleanup memory from global payloads
Feb 23, 2015
d40d791
Promisify writeFile by hand in index tests
Feb 23, 2015
99f9fda
Fix linter errors
Feb 23, 2015
3b9b637
Clean up creation/deletion of global payloads
Feb 23, 2015
dece787
Clean up callbacks in structs
Feb 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Normalize returns for callbacks
  • Loading branch information
John Haley committed Feb 24, 2015
commit deeb885db85d13ee0249fea32f9916435a3f420e
2 changes: 1 addition & 1 deletion generate/input/callbacks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@
],
"return": {
"type": "int",
"noResults": 1,
"noResults": 0,
"success": 0,
"error": -1
}
Expand Down
11 changes: 5 additions & 6 deletions generate/templates/partials/callback_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
this_thread::sleep_for(chrono::milliseconds(1));
}

{% each cbFunction|returnsInfo true false as _return %}
{% each cbFunction|returnsInfo false true as _return %}
{% if _return.isOutParam %}
*{{ _return.name }} = *baton->{{ _return.name }};
{% endif %}
{% endeach %}

return baton->result;
Expand Down Expand Up @@ -84,8 +86,6 @@ void {{ cppClassName }}::{{ cppFunctionName }}_{{ cbFunction.name }}_asyncAfter(
}
}

{{ cbFunction.return.type }} resultStatus;

{% each cbFunction|returnsInfo false true as _return %}
if (result.IsEmpty() || result->IsNativeError()) {
baton->result = {{ cbFunction.return.error }};
Expand All @@ -99,7 +99,7 @@ void {{ cppClassName }}::{{ cppFunctionName }}_{{ cbFunction.name }}_asyncAfter(
baton->result = {{ cbFunction.return.success }};
{% else %}
if (result->IsNumber()) {
baton->result = (int) result->ToNumber()->Value();
baton->result = (int)result->ToNumber()->Value();
}
else {
baton->result = {{ cbFunction.return.noResults }};
Expand Down Expand Up @@ -133,7 +133,6 @@ void {{ cppClassName }}::{{ cppFunctionName }}_{{ cbFunction.name }}_asyncPromis
if (isFulfilled->Value()) {
NanCallback* resultFn = new NanCallback(promise->Get(NanNew("value")).As<Function>());
Handle<v8::Value> result = resultFn->Call(0, argv);
{{ cbFunction.return.type }} resultStatus;

{% each cbFunction|returnsInfo false true as _return %}
if (result.IsEmpty() || result->IsNativeError()) {
Expand All @@ -148,7 +147,7 @@ void {{ cppClassName }}::{{ cppFunctionName }}_{{ cbFunction.name }}_asyncPromis
baton->result = {{ cbFunction.return.success }};
{% else %}
if (result->IsNumber()) {
baton->result = (int) result->ToNumber()->Value();
baton->result = (int)result->ToNumber()->Value();
}
else {
baton->result = {{ cbFunction.return.noResults }};
Expand Down
29 changes: 23 additions & 6 deletions generate/templates/partials/field_accessors.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@
this_thread::sleep_for(chrono::milliseconds(1));
}

{% each field|returnsInfo true false as _return %}
{% each field|returnsInfo false true as _return %}
{% if _return.isOutParam %}
*{{ _return.name }} = *baton->{{ _return.name }};
{% endif %}
{% endeach %}

return baton->result;
Expand Down Expand Up @@ -173,18 +175,25 @@
}
}

{{ field.return.type }} resultStatus;

{% each field|returnsInfo true false as _return %}
{% each field|returnsInfo false true as _return %}
if (result.IsEmpty() || result->IsNativeError()) {
baton->result = {{ field.return.error }};
}
else if (!result->IsNull() && !result->IsUndefined()) {
{% if _return.isOutParam %}
{{ _return.cppClassName }}* wrapper = ObjectWrap::Unwrap<{{ _return.cppClassName }}>(result->ToObject());
wrapper->selfFreeing = false;

baton->{{ _return.name }} = wrapper->GetRefValue();
baton->result = {{ field.return.success }};
{% else %}
if (result->IsNumber()) {
baton->result = (int)result->ToNumber()->Value();
}
else {
baton->result = {{ field.return.noResults }};
}
{% endif %}
}
else {
baton->result = {{ field.return.noResults }};
Expand Down Expand Up @@ -213,18 +222,26 @@
if (isFulfilled->Value()) {
NanCallback* resultFn = new NanCallback(promise->Get(NanNew("value")).As<Function>());
Handle<v8::Value> result = resultFn->Call(0, argv);
{{ field.return.type }} resultStatus;

{% each field|returnsInfo true false as _return %}
{% each field|returnsInfo false true as _return %}
if (result.IsEmpty() || result->IsNativeError()) {
baton->result = {{ field.return.error }};
}
else if (!result->IsNull() && !result->IsUndefined()) {
{% if _return.isOutParam %}
{{ _return.cppClassName }}* wrapper = ObjectWrap::Unwrap<{{ _return.cppClassName }}>(result->ToObject());
wrapper->selfFreeing = false;

baton->{{ _return.name }} = wrapper->GetRefValue();
baton->result = {{ field.return.success }};
{% else %}
if (result->IsNumber()) {
baton->result = (int)result->ToNumber()->Value();
}
else{
baton->result = {{ field.return.noResults }};
}
{% endif %}
}
else {
baton->result = {{ field.return.noResults }};
Expand Down
2 changes: 1 addition & 1 deletion test/tests/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe("Clone", function() {
var sshPrivateKey = local("../id_rsa");

// Set a reasonable timeout here now that our repository has grown.
this.timeout(15000);
this.timeout(30000);

beforeEach(function() {
return NodeGit.Promise.all([
Expand Down