Skip to content

Fix building when a space is in the path #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 1 commit into from
Feb 3, 2015
Merged

Fix building when a space is in the path #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix building when a space is in the path
  • Loading branch information
@thornbill
thornbill committed Feb 3, 2015
commit 0506f4d619026c9410f4eb9e4ef28986716f0707
1 change: 1 addition & 0 deletions lifecycleScripts/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ function build() {
}

builder = path.resolve(".", "node_modules", ".bin", builder);
builder = builder.replace(/\s/g, "\\$&");
var cmd = [prefix, builder, "rebuild", target, debug, distUrl]
.join(" ").trim();

Expand Down
2 changes: 1 addition & 1 deletion lifecycleScripts/retrieveExternalDependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function getVendorLib(name) {
if ((name == "libssh2") && (process.platform !== "win32")) {
return new Promise(function(resolve, reject) {
console.info("[nodegit] Configuring libssh2.");
cp.exec(
cp.execFile(
rooted(vendorPath) + "configure",
{cwd: rooted(vendorPath)},
function(err, stdout, stderr) {
Expand Down