Skip to content

[WIP] Better installation flow #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbranyen merged 7 commits into from
Nov 25, 2014
Merged

[WIP] Better installation flow #287

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4cb8968
Added in --expose-gc flag
tbranyen Nov 22, 2014
8340770
Crank up the timeout
tbranyen Nov 22, 2014
551fd42
Modified revwalk test to only call done once
tbranyen Nov 22, 2014
0a5632c
stop thrashing cpu with GCs
maxkorp Nov 22, 2014
9432ae0
Adds in a BUILD_ONLY environment variable
tbranyen Nov 24, 2014
5b02972
More advanced test script
tbranyen Nov 24, 2014
c4aa958
Fixed tests running on windows
Nov 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modified revwalk test to only call done once
  • Loading branch information
@tbranyen
tbranyen authored and John Haley committed Nov 24, 2014
commit 551fd42a7fc193487f74e0ed14d7397add96cb36
38 changes: 18 additions & 20 deletions test/tests/revwalk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ describe("Revwalk", function() {
var Revwalk = require("../../lib/revwalk");
var Oid = require("../../lib/oid");

// Set a reasonable timeout here now that our repository has grown.
this.timeout(150000);

before(function(done) {
var test = this;
return Repository.open(reposPath).then(function(repository) {
Expand Down Expand Up @@ -81,34 +84,29 @@ describe("Revwalk", function() {
});
});

// This test requires forcing garbage collection, so mocha needs to be run via
// node rather than npm, with a la `node --expose-gc [pathtohmoca] [testglob]`
var testGC = (global.gc ? it : it.skip);
// This test requires forcing garbage collection, so mocha needs to be run
// via node rather than npm, with a la `node --expose-gc [pathtohmoca]
// [testglob]`
var testGC = global.gc ? it : it.skip;

testGC("doesnt segfault when accessing .author() twice", function(done) {
this.timeout(10000);

return Repository.open(reposPath).then(function(repository) {
Repository.open(reposPath).then(function(repository) {
var walker = repository.createRevWalk();
return repository.getMasterCommit().then(function(firstCommitOnMaster) {
var did = false;
walker.walk(firstCommitOnMaster, function(error, commit) {

repository.getMasterCommit().then(function(firstCommitOnMaster) {
walker.walk(firstCommitOnMaster, function(err, commit) {
if (!err && !commit) {
return done();
}

for (var i = 0; i < 1000; i++) {
if (true) {
commit.author().name();
commit.author().email();
}
commit.author().name();
commit.author().email();

global.gc();
}
if (!did) {
done();
did = true;
}
});
});
}).then(function() {
global.gc();
});
});

});