voidcheck string pointers and reenable attr test#266
Merged
Conversation
maxkorp
added a commit
that referenced
this pull request
Nov 11, 2014
voidcheck string pointers and reenable attr test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attr test was failing (and being skipped) because of a segfault. Some libgit2 functions that output to char** just don't even allocate the inner string if they have no output, so we need to voidcheck the inner pointer. Combined with a tweak to make git_attr_get async and to make the templates recognize its return, the test passes.