Skip to content

Add revwalk.hide and revwalk.simplifyFirstParent#234

Merged
tbranyen merged 2 commits intonodegit:masterfrom
orderedlist:revwalk-additions
Oct 9, 2014
Merged

Add revwalk.hide and revwalk.simplifyFirstParent#234
tbranyen merged 2 commits intonodegit:masterfrom
orderedlist:revwalk-additions

Conversation

@orderedlist
Copy link
Copy Markdown
Collaborator

This PR adds the ability to hide OIDs from a revwalker, and the ability to limit the revwalker to only walk first parents.

@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented Oct 9, 2014

Looks like incorrect SHA's in the CI. Was this passing locally for you?

@orderedlist
Copy link
Copy Markdown
Collaborator Author

Yeah, passed locally. Let me dig into the CI. Might need to be more explicit with the initial SHAs I use.

@orderedlist
Copy link
Copy Markdown
Collaborator Author

@tbranyen something's definitely happening with the SHAs. Does the test/repos/workdir repo change?

@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented Oct 9, 2014

It changes whenever NodeGit master is updated. If your revwalk code is expecting a certain order, that can't be guaranteed.

@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented Oct 9, 2014

Hey @orderedlist I have a commit that fixes the output to be correct and makes the tests easier to read. I can push it into your branch if you add me to your fork.

See the change here: #235

@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented Oct 9, 2014

@orderedlist you probably need to rm -rf test/repos as well before your next npm test.

@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented Oct 9, 2014

Ah nevermind, I'll just update the title of my PR and merge it that way. No real difference. Thanks for your help!

@tbranyen tbranyen merged commit 758b06f into nodegit:master Oct 9, 2014
@orderedlist orderedlist deleted the revwalk-additions branch October 9, 2014 23:47
@orderedlist
Copy link
Copy Markdown
Collaborator Author

@tbranyen thanks for the help! Hope to keep adding more in the future!

@tbranyen
Copy link
Copy Markdown
Member

Awesome looking forward to the help @orderedlist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants