Fix intermittent crash on Electron 18+#1951
Merged
Merged
Conversation
78ee046 to
3b997a5
Compare
Contributor
Author
|
CI failures appear to be caused by an npm bug so ill publish the @axosoft/nan package and put it in this PR. |
3b997a5 to
36b8c9c
Compare
36b8c9c to
1a85710
Compare
weedz
pushed a commit
to weedz/nodegit
that referenced
this pull request
Nov 4, 2022
Fix intermittent crash on Electron 18+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not fun to track down. Probably ~3 weeks of work?
This PR bumps nan to a custom version hosted on the axosoft org(could be moved to nodegit if necessary) and bumps the internal field count on object templates to account for the updates made to nan.
more details on what is happening and why, here:
Axosoft/nan#1
and here:
https://github.com/electron/electron/blob/693cf0ebdebb272494610a5ed2e9c405e825813e/patches/node/be_compatible_with_cppgc.patch