Skip to content

Fix memory leaks #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julianmesa-gitkraken wants to merge 18 commits into
base: master
Choose a base branch
from
+217 −26
Open

Fix memory leaks #1944

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
77cdd5c
Fix memory leaks
julianmesa-gitkraken Oct 20, 2022
5926ba1
Fix git_diff_line leak
julianmesa-gitkraken Oct 20, 2022
2900bf1
Fix leak freeing PatchData
julianmesa-gitkraken Oct 20, 2022
6c4e32d
Fix leak
julianmesa-gitkraken Oct 21, 2022
5160975
Fix leaks git str array
julianmesa-gitkraken Oct 25, 2022
9eb357e
Fix leak strdup in oid
julianmesa-gitkraken Oct 25, 2022
06b04c7
Fix leak in GitPatch::ConvenientFromDiff
julianmesa-gitkraken Oct 25, 2022
c8afbe6
Fix leak freeing array from javascript
julianmesa-gitkraken Oct 25, 2022
54087a6
Fix double freeing
julianmesa-gitkraken Oct 25, 2022
7d85533
Fix leak in GitRevwalk::FileHistoryWalk
julianmesa-gitkraken Oct 25, 2022
07a4593
Fix leak on freeing git_index_entry
julianmesa-gitkraken Oct 25, 2022
7b5c85b
Free baton on error processing javascript arguments
julianmesa-gitkraken Oct 26, 2022
e3fd6fe
Fix leak when the out parameter is not self freeing
julianmesa-gitkraken Oct 26, 2022
7a51839
Fix leak strdup getting oid from string
julianmesa-gitkraken Oct 26, 2022
535395f
Fix leaks in sync functions
julianmesa-gitkraken Oct 26, 2022
ee48c70
Fix leaks in extract_signature template
julianmesa-gitkraken Oct 26, 2022
d4981f0
Fix issues with index entries
julianmesa-gitkraken Oct 28, 2022
842196f
Unregister filters before clean the memory
julianmesa-gitkraken Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix leaks in extract_signature template
  • Loading branch information
@julianmesa-gitkraken
julianmesa-gitkraken committed Oct 26, 2022
commit ee48c709843223810fb5fee6807aaa54cdc15164
12 changes: 10 additions & 2 deletions generate/templates/manual/commit/extract_signature.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ NAN_METHOD(GitCommit::ExtractSignature)
if (info[1]->IsString()) {
Nan::Utf8String oidString(Nan::To<v8::String>(info[1]).ToLocalChecked());
baton->commit_id = (git_oid *)malloc(sizeof(git_oid));
baton->commit_idNeedsFree = true;
string str = string(*oidString);
if (git_oid_fromstr(baton->commit_id, str.c_str()) != GIT_OK) {
free(baton->commit_id);
Expand All @@ -40,6 +41,7 @@ NAN_METHOD(GitCommit::ExtractSignature)
}
} else {
baton->commit_id = Nan::ObjectWrap::Unwrap<GitOid>(Nan::To<v8::Object>(info[1]).ToLocalChecked())->GetValue();
baton->commit_idNeedsFree = false;
}

// baton->field
Expand Down Expand Up @@ -97,6 +99,10 @@ void GitCommit::ExtractSignatureWorker::HandleErrorCallback() {
git_buf_dispose(&baton->signature);
git_buf_dispose(&baton->signed_data);

if (baton->commit_idNeedsFree) {
free(baton->commit_id);
}

free(baton->field);

delete baton;
Expand Down Expand Up @@ -155,9 +161,11 @@ void GitCommit::ExtractSignatureWorker::HandleOKCallback()
git_buf_dispose(&baton->signature);
git_buf_dispose(&baton->signed_data);

if (baton->field != NULL) {
free((void *)baton->field);
if (baton->commit_idNeedsFree) {
free(baton->commit_id);
}

free(baton->field);

delete baton;
}