Skip to content

Improve performance disabling asserts and using LTO #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julianmesa-gitkraken wants to merge 2 commits into
base: master
Choose a base branch
from
+62 −1
Open

Improve performance disabling asserts and using LTO #1938

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cda85f
Improve performance using LTO and disabling asserts
julianmesa-gitkraken Jul 8, 2022
42b84b9
Fix linux tests
julianmesa-gitkraken Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix linux tests
  • Loading branch information
@julianmesa-gitkraken
julianmesa-gitkraken committed Sep 29, 2022
commit 42b84b907df5e6bcb18ee4bddd247b881a69de55
12 changes: 11 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
steps:
- name: Install Dependencies for Ubuntu
# git >= 2.18 required for actions/checkout git support
run: apt-get update && apt-get install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt-get update && apt-get install -y git build-essential clang libssl-dev libkrb5-dev libc++-dev wget
run: apt-get update && apt-get install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt-get update && apt-get install -y git build-essential clang-8 lld-8 libssl-dev libkrb5-dev libc++-dev wget
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true

Expand All @@ -29,6 +29,9 @@ jobs:
CC: clang
CXX: clang++
run: |
update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-8 100
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-8 100
update-alternatives --install /usr/bin/ld ld /usr/bin/lld-8 100
mkdir ~/python
cd ~/python
wget https://www.python.org/ftp/python/3.6.15/Python-3.6.15.tgz
Expand Down Expand Up @@ -65,10 +68,17 @@ jobs:
CXX: clang++
npm_config_clang: 1
GYP_DEFINES: use_obsolete_asm=true
AR: "/usr/lib/llvm-8/bin/llvm-ar"
NM: "/usr/lib/llvm-8/bin/llvm-nm"
# ranlib is not needed, and doesn't support .bc files in .a
RANLIB: /bin/true
# There is a race condition in node/generate that needs to be fixed
# Node 16 changed the logic it uses to select it's UID which means to make node run as root and not 1001, we need to chwon the current directory. More Details:
# https://stackoverflow.com/questions/70298238/getting-eaccess-when-running-npm-8-as-root
run: |
update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-8 100
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-8 100
update-alternatives --install /usr/bin/ld ld /usr/bin/lld-8 100
chown root.root -R .
npm set unsafe-perm true
node utils/retry npm install
Expand Down