Skip to content

Statically compile OpenSSL on linux for electron#1905

Merged
ianhattendorf merged 8 commits into
nodegit:masterfrom
zawata:static-openssl
May 2, 2022
Merged

Statically compile OpenSSL on linux for electron#1905
ianhattendorf merged 8 commits into
nodegit:masterfrom
zawata:static-openssl

Conversation

@zawata
Copy link
Copy Markdown
Contributor

@zawata zawata commented Mar 31, 2022

Several fixes included, they should be documented in the code.

Notable Changes:

  • a code patching system
    • only used to fix openssl old linux OS's(GLIBC <= 2.25) for now but can be expanded in the future if necessary
  • openssl configure and build support for linux
    • notably there is a flag passed here to hide all openssl symbols, without this, nodegit would segfault in cases where the electron environment has loaded in openssl
  • Apparently we were building and shipping some node binaries without code in them, this was an artifact of making action-only targets but not declaring them as action-only. I fixed that.
  • Also configured openssl on linux and mac to only build and install the headers and libs. we no longer build the additional apps, fuzzers, and docs. should result in a small speed up

Copy link
Copy Markdown
Contributor

@julianmesa-gitkraken julianmesa-gitkraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

Comment thread vendor/patches/openssl/001-unix_force_getentropy_dso_lookup.patch Outdated
@zawata zawata force-pushed the static-openssl branch 2 times, most recently from a7a773f to 9ba7696 Compare April 1, 2022 16:41
@ianhattendorf ianhattendorf merged commit bc809f1 into nodegit:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants