Skip to content

Update windows 2016 CI to 2019 #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianhattendorf merged 2 commits into from
Mar 17, 2022
Merged

Update windows 2016 CI to 2019 #1897

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c303953
Update windows 2016 CI to 2019
julianmesa-gitkraken Mar 11, 2022
0f897b2
Update node-pre-gyp to use @mapbox/node-pre-gyp
julianmesa-gitkraken Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update windows 2016 CI to 2019 
To update Windows box we need to upgrade node-gyp, so we need python 3.6 in ubuntu 16.04, but last version is 3.5. This is the reason Python 3.6 is build from source.
  • Loading branch information
@julianmesa-gitkraken
julianmesa-gitkraken committed Mar 11, 2022
commit c303953efd39bdb3b7acf16fb9151d191fa1ff78
18 changes: 16 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,24 @@ jobs:
steps:
- name: Install Dependencies for Ubuntu
# git >= 2.18 required for actions/checkout git support
run: apt-get update && apt-get install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt-get update && apt-get install -y git build-essential clang python3 libssl-dev libkrb5-dev libc++-dev
run: apt-get update && apt-get install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt-get update && apt-get install -y git build-essential clang libssl-dev libkrb5-dev libc++-dev wget
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true

- name: Setup python 3.6
env:
CC: clang
CXX: clang++
run: |
mkdir ~/python
cd ~/python
wget https://www.python.org/ftp/python/3.6.15/Python-3.6.15.tgz
tar -xvf Python-3.6.15.tgz
cd Python-3.6.15
./configure
make
make install

- name: Setup Environment
run: |
mkdir ~/.ssh_tests
Expand Down Expand Up @@ -142,7 +156,7 @@ jobs:
matrix:
node: [12, 14, 16]
arch: [x86, x64]
runs-on: windows-2016
runs-on: windows-2019
steps:
- name: Setup Environment
run: |
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"json5": "^2.1.0",
"lodash": "^4.17.14",
"nan": "^2.14.1",
"node-gyp": "^7.1.2",
"node-pre-gyp": "^0.13.0",
"node-gyp": "^9.0.0",
"@mapbox/node-pre-gyp": "^1.0.8",
"ramda": "^0.25.0",
"tar-fs": "^1.16.3"
},
Expand Down