lint fixes

nodegit · wmertens · Feb 27, 2021 · Feb 27, 2021 · Jan 26, 2023 · Mar 7, 2021
commit cfa5cd7cd77fc558fd1cb2c4a3288d59c0e16636
diff --git a/examples/apps/git_profanity_check.js b/examples/apps/git_profanity_check.js
@@ -10,6 +10,7 @@
 //
 //     node git_profanity_check some/repo/.git
 //
+// eslint-disable-next-line node/shebang
 var git = require("../../");
 
 var curses = ["put", "curse", "words", "here"];

diff --git a/examples/index-add-and-remove.js b/examples/index-add-and-remove.js
@@ -13,7 +13,7 @@ nodegit.Repository.open(path.resolve(__dirname, "../.git"))
       var fileNames = Object.keys(fileContent);
 
       return Promise.all(fileNames.map(function(fileName) {
-        fse.writeFile(
+        return fse.writeFile(
           path.join(repo.workdir(), fileName), fileContent[fileName]);
       }))
 
@@ -87,7 +87,7 @@ nodegit.Repository.open(path.resolve(__dirname, "../.git"))
         return index.addAll(
           "newFile*",
           nodegit.Index.ADD_OPTION.ADD_CHECK_PATHSPEC,
-          function(path, matchedPattern) {
+          function(path, _matchedPattern) {
             if (path == "newFile1") {
               return 0; // add the file
             }

diff --git a/generate/scripts/generateJson.js b/generate/scripts/generateJson.js
@@ -201,6 +201,7 @@ module.exports = function generateJson() {
       else if (enumerable.owner) {
         return true;
       }
+      return false;
     });
 
     var override = descriptor.enums[enumerable.typeName] || {};

diff --git a/generate/scripts/generateMissingTests.js b/generate/scripts/generateMissingTests.js
@@ -8,7 +8,7 @@ module.exports = function generateMissingTests() {
   var output = {};
 
   function findMissingTest(idef) {
-    return new Promise(function(resolve, reject) {
+    return new Promise(function(resolve) {
       var testFilePath = path.join(testFilesPath, idef.filename + ".js");
       var result = {};
 

diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -11,7 +11,7 @@ var callbackDefs = require("../input/callbacks.json");
 var descriptor = require("../input/descriptor.json");
 var libgit2 = require("../input/libgit2-docs.json");
 
-var cTypes = libgit2.groups.map(function(group) { return group[0];});
+// var cTypes = libgit2.groups.map(function(group) { return group[0];});
 
 var cTypeMappings = {
   "char": "String",
@@ -82,6 +82,7 @@ var Helpers = {
   hasConstructor: function(type, normalizedType) {
     if (normalizedType && descriptor.types[normalizedType.substr(4)]) {
       var descriptorEntry = descriptor.types[normalizedType.substr(4)];
+      // eslint-disable-next-line no-prototype-builtins
       if (descriptorEntry.hasOwnProperty('hasConstructor')) {
         return descriptorEntry.hasConstructor;
       }
@@ -116,6 +117,7 @@ var Helpers = {
         libgitType = type[1];
         return true;
       }
+      return false;
     });
 
     return libgitType;
@@ -149,6 +151,7 @@ var Helpers = {
           cbFieldName = cbField.name;
           return true;
         }
+        return false;
       });
 
       if (cbFieldName) {
@@ -223,7 +226,7 @@ var Helpers = {
       return fnDef;
     });
 
-    var typeDefOverrides = descriptor.types[typeDef.typeName] || {};
+    typeDefOverrides = descriptor.types[typeDef.typeName] || {};
     var functionOverrides = typeDefOverrides.functions || {};
     typeDef.functions.forEach(function(fnDef) {
       Helpers.decorateFunction(fnDef, typeDef, functionOverrides[fnDef.cFunctionName] || {}, enums);
@@ -233,7 +236,7 @@ var Helpers = {
   },
 
   decorateField: function(field, allFields, fieldOverrides, enums) {
-    var normalizeType = Helpers.normalizeCtype(field.type);
+    // var normalizeType = Helpers.normalizeCtype(field.type);
 
     field.cType = field.type;
     field.cppFunctionName = utils.titleCase(field.name);

diff --git a/generate/scripts/utils.js b/generate/scripts/utils.js
@@ -55,7 +55,7 @@ var util = {
   },
 
   titleCase: function(str) {
-    return str.split(/_|\//).map(function(val, index) {
+    return str.split(/_|\//).map(function(val) {
       if (val.length) {
         return val[0].toUpperCase() + val.slice(1);
       }

diff --git a/generate/templates/filters/title_case.js b/generate/templates/filters/title_case.js
@@ -1,5 +1,5 @@
 module.exports = function(str) {
-  return str.split(/_|\//).map(function(val, index) {
+  return str.split(/_|\//).map(function(val) {
     if (val.length) {
       return val[0].toUpperCase() + val.slice(1);
     }

diff --git a/guides/repositories/index.js b/guides/repositories/index.js
@@ -11,7 +11,7 @@ var pathToRepo = require("path").resolve("../my-git-projects/my-project");
 // In NodeGit we use Promises to make callbacks easier to deal with.
 //
 // For more information visit https://www.promisejs.org/
-NodeGit.Repository.open(pathToRepo).then(function (repo) {
+NodeGit.Repository.open(pathToRepo).then(function (_repo) {
   // In this function we have a repo object that we can perform git operations
   // on.
   // NOTE: Many NodeGit objects will appear as empty objects if inspected in
@@ -21,14 +21,14 @@ NodeGit.Repository.open(pathToRepo).then(function (repo) {
 // Promises will swallow errors and not report them unless you have supplied
 // a second function to the `.then` or end the chain with either a `.catch` or
 // a `.done`
-.then(function (successfulResult) {
+.then(function (_successfulResult) {
   // This is the first function of the then which contains the successfully
   // calculated result of the promise
-}, function (reasonForFailure) {
+}, function (_reasonForFailure) {
   // This is the second function of the then which contains the reason the
   // promise failed
 })
-.catch(function (reasonForFailure) {
+.catch(function (_reasonForFailure) {
   // You can also provide a catch function which will contain the reason why
   // any above promises that weren't handled have failed
 })

diff --git a/guides/repositories/initializing/index.js b/guides/repositories/initializing/index.js
@@ -16,14 +16,14 @@ var isBare = 0;
 // In NodeGit we use Promises to make callbacks easier to deal with.
 //
 // For more information visit https://www.promisejs.org/
-NodeGit.Repository.init(pathToRepo, isBare).then(function (repo) {
+NodeGit.Repository.init(pathToRepo, isBare).then(function (_repo) {
   // In this function we have a repo object that we can perform git operations
   // on.
 
   // Note that with a new repository many functions will fail until there is
   // an initial commit.
 })
-.catch(function (reasonForFailure) {
+.catch(function (_reasonForFailure) {
   // If the repo cannot be created for any reason we can handle that case here.
   // NodeGit won't init a repo over a pre-existing repo.
 });
diff --git a/lib/remote.js b/lib/remote.js
@@ -22,6 +22,7 @@ Remote.lookup = lookupWrapper(Remote);
  *                                  connection.
  * @async
  */
+// eslint-disable-next-line no-self-assign
 Remote.prototype.referenceList = Remote.prototype.referenceList;
 
 NodeGit.Remote.COMPLETION_TYPE = {};

diff --git a/lib/repository.js b/lib/repository.js
@@ -1160,7 +1160,7 @@ Repository.prototype.getStatusExt = function (opts) {
  */
 Repository.prototype.getSubmoduleNames = function () {
   var names = [];
-  var submoduleCallback = function (submodule, name, payload) {
+  var submoduleCallback = function (_submodule, name, _payload) {
     names.push(name);
   };
 
@@ -1334,11 +1334,12 @@ Repository.prototype.rebaseBranches = function (
       });
   }
 
-  return Promise.all([
-    repo.getReference(branch),
-    upstream ? repo.getReference(upstream) : null,
-    onto ? repo.getReference(onto) : null,
-  ])
+  return promiseChain.then(() =>
+    Promise.all([
+      repo.getReference(branch),
+      upstream ? repo.getReference(upstream) : null,
+      onto ? repo.getReference(onto) : null,
+    ])
     .then(function (refs) {
       return Promise.all([
         NodeGit.AnnotatedCommit.fromRef(repo, refs[0]),
@@ -1378,7 +1379,8 @@ Repository.prototype.rebaseBranches = function (
     })
     .then(function () {
       return repo.getBranchCommit("HEAD");
-    });
+    })
+  );
 };
 
 /**

diff --git a/lib/tree.js b/lib/tree.js
@@ -109,7 +109,7 @@ Tree.prototype.getEntry = function(filePath) {
  * Return the path of this tree, like `/lib/foo/bar`
  * @return {String}
  */
-Tree.prototype.path = function(blobsOnly) {
+Tree.prototype.path = function(_blobsOnly) {
   return this.entry ? this.entry.path() : "";
 };
 
@@ -145,7 +145,7 @@ Tree.prototype.walk = function(blobsOnly) {
       return event.emit("error", error);
     }
 
-    tree.entries().forEach(function (entry, entryIndex) {
+    tree.entries().forEach(function (entry, _entryIndex) {
       if (!blobsOnly || entry.isFile() && !entries.has(entry)) {
         event.emit("entry", entry);
         entries.add(entry);

diff --git a/lifecycleScripts/clean.js b/lifecycleScripts/clean.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line node/no-unpublished-require
 var cleanForPublish = require("clean-for-publish");
 var path = require("path");
 

diff --git a/lifecycleScripts/install.js b/lifecycleScripts/install.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-process-exit */
 var buildFlags = require("../utils/buildFlags");
 var spawn = require("child_process").spawn;
 var path = require("path");

diff --git a/lifecycleScripts/preinstall.js b/lifecycleScripts/preinstall.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-process-exit */
 var path = require("path");
 var local = path.join.bind(path, __dirname);
 

diff --git a/test/runner.js b/test/runner.js
@@ -3,6 +3,7 @@ var path = require("path");
 var local = path.join.bind(path, __dirname);
 var exec = require('../utils/execPromise');
 
+// eslint-disable-next-line no-unused-vars
 var NodeGit = require('..');
 
 var workdirPath = local("repos/workdir");

diff --git a/test/tests/blob.js b/test/tests/blob.js
@@ -290,7 +290,7 @@ describe("Blob", function() {
           return commitFile(
             test.repository,
             newFileName,
-            "this\nis\nfun\guys",
+            "this\nis\nfunguys",
             "added LF ending file"
           );
         })
@@ -334,7 +334,7 @@ describe("Blob", function() {
           return commitFile(
             test.repository,
             newFileName,
-            "this\nis\nfun\guys",
+            "this\nis\nfunguys",
             "added LF ending file"
           );
         })
@@ -498,7 +498,7 @@ describe("Blob", function() {
           return commitFile(
             test.repository,
             newFileName,
-            "this\nis\nfun\guys",
+            "this\nis\nfunguys",
             "added LF ending file"
           );
         })
@@ -538,7 +538,7 @@ describe("Blob", function() {
           return commitFile(
             test.repository,
             newFileName,
-            "this\nis\nfun\guys",
+            "this\nis\nfunguys",
             "added LF ending file"
           );
         })

diff --git a/test/tests/branch.js b/test/tests/branch.js
@@ -112,10 +112,10 @@ describe("Branch", function() {
 
     // don't force the move
     return Branch.move(branch, branchName2, 0)
-      .then(function(branch) {
+      .then(function(_branch) {
         return Promise.reject(new Error(
           "should not be able to rename the branch"));
-      }, function(error) {
+      }, function(_error) {
         return Promise.resolve()
           .then(function() {
             // force the move
@@ -150,10 +150,10 @@ describe("Branch", function() {
         return Branch.createFromAnnotated(
           repo, branchName, annotatedCommit, 0);
       })
-      .then(function(branch) {
+      .then(function(_branch) {
         return Promise.reject(new Error(
           "should not be able to create the branch"));
-      }, function(error) {
+      }, function(_error) {
         return Promise.resolve()
           .then(function() {
             // force the branch creation

diff --git a/test/tests/checkout.js b/test/tests/checkout.js
@@ -29,7 +29,7 @@ describe("Checkout", function() {
     var test = this;
 
     return Checkout.head(test.repository)
-    .then(function(blob) {
+    .then(function(_blob) {
       var packageContent = fse.readFileSync(packageJsonPath, "utf-8");
 
       assert.ok(~packageContent.indexOf("\"ejs\": \"~1.0.0\","));
@@ -175,7 +175,7 @@ describe("Checkout", function() {
     .then(() => {
       return test.repository.checkoutBranch(testBranchName);
     })
-    .then((branch) => {
+    .then((_branch) => {
       fse.writeFileSync(packageJsonPath, "\n");
 
       return test.repository.refreshIndex()
@@ -196,7 +196,7 @@ describe("Checkout", function() {
       return test.repository.createCommit("refs/heads/" + testBranchName,
         signature, signature, "we made breaking changes", oid, [ourCommit]);
     })
-    .then((commit) => {
+    .then((_commit) => {
       return Promise.all([
         test.repository.getBranchCommit(testBranchName),
         test.repository.getBranchCommit("master")