Skip to content

First stab at #1800 (async/await in examples)#1802

Merged
implausible merged 10 commits into
nodegit:masterfrom
julien-c:syntax_examples
Mar 12, 2021
Merged

First stab at #1800 (async/await in examples)#1802
implausible merged 10 commits into
nodegit:masterfrom
julien-c:syntax_examples

Conversation

@julien-c
Copy link
Copy Markdown
Contributor

@julien-c julien-c commented Oct 9, 2020

The only non-syntactic changes are:

  • used built-in fs instead of fse as the methods are there already
  • fixed a few deprecation notices

Feedback welcome

@julien-c
Copy link
Copy Markdown
Contributor Author

Anyone? :) @implausible @ianhattendorf

Also explicitly referencing #1800

@implausible
Copy link
Copy Markdown
Member

Yes, we see this. I can't promise I will get to it immediately, but will try to land it before the next release. Thanks for your effort!

Copy link
Copy Markdown
Member

@implausible implausible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@implausible implausible merged commit c1acc68 into nodegit:master Mar 12, 2021
@julien-c julien-c deleted the syntax_examples branch May 3, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants