Skip to content

Optionally retrieve more data on commit walk #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 2 commits into from
Sep 26, 2019
Merged

Optionally retrieve more data on commit walk #1728

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ecd368
commitWalk optionally returns plain objects with gpgSignature data
implausible Sep 25, 2019
d7c9860
Use const qualifier more; use static_cast for void *
implausible Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use const qualifier more; use static_cast for void *
  • Loading branch information
@implausible
implausible committed Sep 26, 2019
commit d7c9860bb2b8a75b6046fa58cd5c03835ea54d63
12 changes: 6 additions & 6 deletions generate/templates/manual/revwalk/commit_walk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CommitModel {
signedData({ 0, 0, 0 })
{
if (fetchSignature) {
int error = git_commit_extract_signature(
const int error = git_commit_extract_signature(
&signature,
&signedData,
git_commit_owner(commit),
Expand All @@ -33,7 +33,7 @@ class CommitModel {
}
}

size_t parentCount = git_commit_parentcount(commit);
const size_t parentCount = git_commit_parentcount(commit);
parentIds.reserve(parentCount);
for (size_t parentIndex = 0; parentIndex < parentCount; ++parentIndex) {
parentIds.push_back(git_oid_tostr_s(git_commit_parent_id(commit, parentIndex)));
Expand Down Expand Up @@ -128,7 +128,7 @@ NAN_METHOD(GitRevwalk::CommitWalk) {
baton->max_count = Nan::To<unsigned int>(info[0]).FromJust();
std::vector<CommitModel *> *out = new std::vector<CommitModel *>;
out->reserve(baton->max_count);
baton->out = reinterpret_cast<void *>(out);
baton->out = static_cast<void *>(out);
if (info.Length() == 3 && info[1]->IsObject()) {
v8::Local<v8::Object> options = Nan::To<v8::Object>(info[1]).ToLocalChecked();
v8::Local<v8::String> propName = Nan::New("returnPlainObjects").ToLocalChecked();
Expand All @@ -152,7 +152,7 @@ NAN_METHOD(GitRevwalk::CommitWalk) {
void GitRevwalk::CommitWalkWorker::Execute() {
giterr_clear();

std::vector<CommitModel *> *out = reinterpret_cast<std::vector<CommitModel *> *>(baton->out);
std::vector<CommitModel *> *out = static_cast<std::vector<CommitModel *> *>(baton->out);
for (int i = 0; i < baton->max_count; i++) {
git_oid next_commit_id;
baton->error_code = git_revwalk_next(&next_commit_id, baton->walk);
Expand Down Expand Up @@ -203,8 +203,8 @@ void GitRevwalk::CommitWalkWorker::Execute() {

void GitRevwalk::CommitWalkWorker::HandleOKCallback() {
if (baton->out != NULL) {
std::vector<CommitModel *> *out = reinterpret_cast<std::vector<CommitModel *> *>(baton->out);
unsigned int size = out->size();
std::vector<CommitModel *> *out = static_cast<std::vector<CommitModel *> *>(baton->out);
const unsigned int size = out->size();
Local<Array> result = Nan::New<Array>(size);
for (unsigned int i = 0; i < size; i++) {
CommitModel *commitModel = out->at(i);
Expand Down