Skip to content

Fix behaviour of Repository#getReferences #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 2 commits into from
Jul 25, 2019
Merged

Fix behaviour of Repository#getReferences #1708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0bb116
:bug: Fix behaviour of Repository#getReferences; filter and map do no…
tiggerite Jul 25, 2019
58ab918
Reference.TYPE.LISTALL is depreciated in favour of TYPE.ALL
tiggerite Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
🐛 Fix behaviour of Repository#getReferences; filter and map do not wo… 
…rk in-place
  • Loading branch information
@tiggerite
tiggerite committed Jul 25, 2019
commit d0bb116f9e4946ce85fa77e6d2540f334ec69ee0
12 changes: 5 additions & 7 deletions lib/repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,14 +351,12 @@ Repository.initExt = function(repo_path, opts) {

Repository.getReferences = function(repo, type, refNamesOnly) {
return repo.getReferences().then(function(refList) {
var filteredRefList = refList;

filteredRefList.filter(function(reference) {
return type == Reference.TYPE.LISTALL || reference.type === type;
var filteredRefList = refList.filter(function(reference) {
return type === Reference.TYPE.LISTALL || reference.type === type;
});

if (refNamesOnly) {
filteredRefList.map(function(reference) {
return filteredRefList.map(function(reference) {
return reference.name();
});
}
Expand Down Expand Up @@ -1255,8 +1253,8 @@ Repository.prototype.getReferenceCommit = function(name, callback) {
* @param {Reference.TYPE} type Type of reference to look up
* @return {Array<String>}
*/
Repository.prototype.getReferenceNames = function(type, callback) {
return Repository.getReferences(this, type, true, callback);
Repository.prototype.getReferenceNames = function(type) {
return Repository.getReferences(this, type, true);
};

/**
Expand Down