Skip to content

Remove NSEC #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Jul 12, 2019
Merged

Remove NSEC #1699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove NSEC 
It seems that since we've been building without NSEC, if you operate on a repository that had been cloned without NSEC, using NSEC to perform working directory diffs can be incredibly slow. To mitigate massive slow downs, we'll turn this off for now. It can still be enabled and recompiled on a fork of NodeGit fairly easily.
  • Loading branch information
@implausible
implausible committed Jul 12, 2019
commit d89446c2d6c7767a6a827cd0d92c5246787eafa3
6 changes: 5 additions & 1 deletion vendor/libgit2.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
"GIT_SSH_MEMORY_CREDENTIALS",
"LIBGIT2_NO_FEATURES_H",
"GIT_SHA1_COLLISIONDETECT",
"GIT_USE_NSEC",
# "GIT_USE_NSEC", We've been shipping without NSEC for awhile
# Turning NSEC on should be left up to application maintainer
# There may be negative performance impacts using nodegit with
# NSEC turned on in a repository that was cloned with nodegit
# with NSEC turned off
"GIT_HTTPS",
# Node's util.h may be accidentally included so use this to guard
# against compilation error.
Expand Down