Skip to content

Implement faster file history walk #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 4 commits into from
May 20, 2019
Merged

Implement faster file history walk #1676

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0eba069
Implement faster file history walk
ianhattendorf May 16, 2019
6231c50
File history walk: include both new and old file paths when renamed
ianhattendorf May 17, 2019
e3ed916
File history walk: include merge commit if trees have changed
ianhattendorf May 17, 2019
24cb2bf
File history walk: memory management
ianhattendorf May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
File history walk: memory management
  • Loading branch information
@ianhattendorf
ianhattendorf committed May 20, 2019
commit 24cb2bfbb0f886ddfc022e6535756b7dc30a679e
8 changes: 5 additions & 3 deletions generate/templates/manual/revwalk/file_history_walk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,10 @@ void GitRevwalk::FileHistoryWalkWorker::Execute()
}

delete fileHistoryEvent;
git_commit_free(parentCommit);
git_tree_free(parentTree);

if (firstMatchingParentIndex.first) {
git_commit_free(parentCommit);
git_tree_free(parentTree);
if (firstMatchingParentIndex.first) {
break;
}
}
Expand Down Expand Up @@ -414,6 +414,8 @@ void GitRevwalk::FileHistoryWalkWorker::Execute()
baton->out = NULL;
baton->error = git_error_dup(git_error_last());
}
free((void *)baton->file_path);
baton->file_path = NULL;
}

void GitRevwalk::FileHistoryWalkWorker::HandleOKCallback()
Expand Down