Skip to content

Clean up some dangerous memory accesses in callbacks #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 3 commits into from
Mar 4, 2019
Merged

Clean up some dangerous memory accesses in callbacks #1642

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e891ce
Add ignorable callback arguments
implausible Mar 4, 2019
dc7e7cd
Update FilterSource to have an async `repo` getter
implausible Mar 4, 2019
e749e90
Use more aggressive garbage collect routine in filter suite
implausible Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use more aggressive garbage collect routine in filter suite
  • Loading branch information
@implausible
implausible committed Mar 4, 2019
commit e749e9063389cae9d98aaebf17660cdf941c7894
19 changes: 12 additions & 7 deletions test/tests/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ var assert = require("assert");
var fse = require("fs-extra");
var path = require("path");
var local = path.join.bind(path, __dirname);
var garbageCollect = require("../utils/garbage_collect.js");

describe("Filter", function() {
var NodeGit = require("../../");
Expand Down Expand Up @@ -216,7 +217,7 @@ describe("Filter", function() {
}, 0)
.then(function(result) {
assert.strictEqual(result, NodeGit.Error.CODE.OK);
global.gc();
garbageCollect();

return fse.writeFile(
packageJsonPath,
Expand Down Expand Up @@ -338,7 +339,8 @@ describe("Filter", function() {
return Checkout.head(test.repository, opts);
})
.then(function() {
global.gc();
garbageCollect();

return Registry.unregister(filterName);
})
.then(function(result) {
Expand Down Expand Up @@ -637,7 +639,7 @@ describe("Filter", function() {
);
assert.notStrictEqual(readmeContent, message);
fse.writeFileSync(readmePath, "whoa", "utf8");
global.gc();
garbageCollect();

var opts = {
checkoutStrategy: Checkout.STRATEGY.FORCE,
Expand Down Expand Up @@ -725,7 +727,7 @@ describe("Filter", function() {
cleanup: function() {}
}, 0)
.then(function(result) {
global.gc();
garbageCollect();
assert.strictEqual(result, NodeGit.Error.CODE.OK);
})
.then(function() {
Expand All @@ -742,7 +744,7 @@ describe("Filter", function() {
);
})
.then(function(oid) {
global.gc();
garbageCollect();
return test.repository.getHeadCommit();
})
.then(function(commit) {
Expand All @@ -755,7 +757,7 @@ describe("Filter", function() {
postInitializeReadmeContents, "testing commit contents"
);
assert.strictEqual(commit.message(), "test commit");
global.gc();
garbageCollect();

return commit.getEntry("README.md");
})
Expand Down Expand Up @@ -842,7 +844,7 @@ describe("Filter", function() {
);
assert.notEqual(packageContent, "");

global.gc();
garbageCollect();
return fse.writeFile(
packageJsonPath,
"Changing content to trigger checkout",
Expand Down Expand Up @@ -1131,6 +1133,9 @@ describe("Filter", function() {
paths: "package.json"
};
return Checkout.head(test.repository, opts);
})
.then(function() {
garbageCollect();
});
});
});
Expand Down