Skip to content

Update LibGit2 docs to v0.28.0 #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 3 commits into from
Feb 15, 2019
Merged

Update LibGit2 docs to v0.28.0 #1631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3fd15b
Update LibGit2 docs to v0.28.0
implausible Feb 14, 2019
a4844f6
Deprecate enums/fields that are missing/deprecated in libgit2 now
implausible Feb 15, 2019
d2e3e14
Fix deprecations in test suite
implausible Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix deprecations in test suite
  • Loading branch information
@implausible
implausible committed Feb 15, 2019
commit d2e3e14e36800d3b1d12e179a711da4f3a7ac6eb
4 changes: 2 additions & 2 deletions lib/reference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Reference.lookup = LookupWrapper(Reference);
* @return {Boolean}
*/
Reference.prototype.isConcrete = function() {
return this.type() == Reference.TYPE.OID;
return this.type() == Reference.TYPE.DIRECT;
};

/**
Expand Down Expand Up @@ -75,7 +75,7 @@ const getTerminal = (repo, refName, depth = 10, prevRef = null) => {

return NodeGit.Reference.lookup(repo, refName)
.then((ref) => {
if (ref.type() === NodeGit.Reference.TYPE.OID) {
if (ref.type() === NodeGit.Reference.TYPE.DIRECT) {
return {
error: NodeGit.Error.CODE.OK,
out: ref
Expand Down
2 changes: 1 addition & 1 deletion test/tests/diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ describe("Diff", function() {
})
.then(function([headTree, index]) {
const diffOptions = new NodeGit.DiffOptions();
if (index.caps() & Index.CAP.IGNORE_CASE !== 0) {
if (index.caps() & Index.CAPABILITY.IGNORE_CASE !== 0) {
diffOptions.flags |= Diff.OPTION.IGNORE_CASE;
}

Expand Down