Skip to content

Fix return type for Reference.isHead (typed as boolean, but returns a number) #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsabanin wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix return type for Reference.isHead (typed as boolean, but returns a number) #1498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a3fa7e
Fix return type for Reference.isHead (typed as boolean, but returns a…
dsabanin May 17, 2018
e2ae1a9
Make isHead() test more strict about the return value.
dsabanin May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make isHead() test more strict about the return value.
  • Loading branch information
@dsabanin
dsabanin authored May 17, 2018
commit e2ae1a92f2c0a22a2fa95a9bea8d78dabe67fee7
2 changes: 1 addition & 1 deletion test/tests/branch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe("Branch", function() {

return repo.getBranch("master")
.then(function(branch) {
assert.ok(branch.isHead());
assert.strictEqual(branch.isHead(), true);
});
});

Expand Down