Skip to content

Remove git_commit_tree which duplicates commit.getTree() #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rcjsuen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove git_commit_tree which duplicates commit.getTree() #1267

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da88f3
Remove handwritten commit.getTree() function
rcjsuen Dec 27, 2017
0583a1d
Merge branch 'master' into remove-commit-tree
rcjsuen Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into remove-commit-tree
  • Loading branch information
@rcjsuen
rcjsuen committed Dec 29, 2018
commit 0583a1dc276f499001967733bdec9ff8a2929f5e
5 changes: 4 additions & 1 deletion test/tests/diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,10 @@ describe("Diff", function() {
return test.repository.getHeadCommit();
})
.then(function(headCommit) {
return headCommit.tree();
return Promise.all([
headCommit.tree(),
test.repository.index()
]);
})
.then(function([headTree, index]) {
const diffOptions = new NodeGit.DiffOptions();
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.