Skip to content

Added tests for Branch #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
Jan 28, 2017
Merged

Added tests for Branch #1181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa1a32
Make `Branch.createFromAnnotated` async
rcjsuen Jan 28, 2017
b88d332
Added tests for Branch
rcjsuen Jan 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make Branch.createFromAnnotated async 
The function was originally synchronous which meant it would return
something on regardless of whether it succeeded (a branch) or failed
(an error code). This forces the client to have to check whether the
returned object is an error code or an object. Change the function to
be asynchronous instead so that clients can use the resolved or
rejected promise to easily determine whether the branch was
successfully created or not.
  • Loading branch information
@rcjsuen
rcjsuen committed Jan 28, 2017
commit 9fa1a3260bae7d8673a60d2c78a20f73ca76fa62
4 changes: 4 additions & 0 deletions generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@
}
},
"git_branch_create_from_annotated": {
"isAsync": true,
"args": {
"ref_out": {
"isReturn": true
Expand All @@ -193,6 +194,9 @@
"force": {
"isOptional": true
}
},
"return": {
"isErrorCode": true
}
},
"git_branch_next": {
Expand Down