Repository navigation
npm rebuild fails (lifecycleScripts/clean should not delete lifecycleScripts!) #576
Description
After successfully running npm install --save nodegit, a subsequent npm rebuild yields:
> nodegit@0.4.0 install /Users/michael/whatever/node_modules/nodegit
> node lifecycleScripts/install
module.js:340
throw err;
^
Error: Cannot find module '/Users/michael/whatever/node_modules/nodegit/lifecycleScripts/install'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:935:3Probably because the install script deletes the lifecycleScripts directory!
nodegit/lifecycleScripts/clean.js
Line 46 in 0841799
Activity
maxkorp commentedon May 18, 2015
This is already fixed in master. Waiting for one or two other bugs before publishing.
mhart commentedon May 18, 2015
Ah, gotcha – sorry, I didn't look at package.json in master.
That line is still in the clean script though – does it make sense that it should delete itself?
maxkorp commentedon May 18, 2015
Yeah, I'd think so. The point of that scripts is like a true "kill everything unneeded" deal for maximizing space savings, assuming a completed install. even without, a rebuild will fail (several of the node modules used for installation are removed since theyre not needed for runtime). I'm more tempted to delete the script entirely, since everyone seems to have varying expectations.