Path issues windows #522

Activity

1. tbranyen commented on Mar 30, 2015

   

   tbranyen

   on Mar 30, 2015

   Member

   More actions

   Git uses forward slashes internally, we should never ever change them to be back slashes.
2. Globegitter commented on Mar 30, 2015

   

   Globegitter

   on Mar 30, 2015

   Author

   More actions

   ahh ok, so what is the recommend approach on windows then? Just not use the nodejs path module?
3. tbranyen commented on Mar 30, 2015

   

   tbranyen

   on Mar 30, 2015

   Member

   More actions

   Node normalizes paths for you. Can you paste an example where this isn't true?
4. Globegitter commented on Mar 30, 2015

   

   Globegitter

   on Mar 30, 2015

   Author

   More actions

   That is exactly the problem in this case - node normalizes the path to windows style, so path\to\file but git uses path/to/file.
5. tbranyen commented on Mar 30, 2015

   

   tbranyen

   on Mar 30, 2015

   Member

   More actions

   Try using: https://nodejs.org/api/path.html#path_path_format_pathobject
6. tbranyen commented on Apr 20, 2015

   

   tbranyen

   on Apr 20, 2015

   Member

   More actions

   I think this is out of the scope of NodeGit, which is attempting to bind 1:1 to libgit2 and where possible provide some convenience over repetitive tasks. By allowing either Unix or Windows style, we'd be breaking a convention from within Git.

   You can normalize with a simple enough replace regex: path = path.replace(/\\/g, '/');
7. tbranyen

   closed this as completedon Apr 20, 2015
8. maxkorp commented on Apr 22, 2015

   

   maxkorp

   on Apr 22, 2015

   Collaborator

   More actions

   I agree that it's out of scope, but just a small suggestion, @Globegitter could you not call path.normalize on the returned value, like so?

   path.normalize(patch.oldFile().path());