You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tbranyen I did wonder why that didn't work. I noticed the segfault too, I'll hopefully be able to address that tonight. I've been doing a bit of work on the C++ side, updated libgit2 to a recent development version (on advice from the libgit2 devs), and have been asynchronizing as much as I could. I also re-did error, as libgit2 changed the way they made errors.
@tbranyen I am sure I'm doing a bunch of memory management improperly, and would love to fix it, but valgrind is telling me not to trust it on 10.8. I will have to dust off my ancient linux box for this.
Activity
tbranyen commentedon Mar 15, 2013
Fixed that problem with an undocumented Travis-CI feature I found here: https://twitter.com/travisci/status/288390896339267584
Now we have a seg fault 👎
faceleg commentedon Mar 15, 2013
@tbranyen I did wonder why that didn't work. I noticed the segfault too, I'll hopefully be able to address that tonight. I've been doing a bit of work on the C++ side, updated libgit2 to a recent development version (on advice from the libgit2 devs), and have been asynchronizing as much as I could. I also re-did error, as libgit2 changed the way they made errors.
tbranyen commentedon Mar 17, 2013
valgrind node ../node_modules/nodeunit/bin/nodeunit convenience-commit.jstry this command @faceleg it's pumping out a ton of invalid read errorsfaceleg commentedon Mar 17, 2013
@tbranyen I am sure I'm doing a bunch of memory management improperly, and would love to fix it, but valgrind is telling me not to trust it on 10.8. I will have to dust off my ancient linux box for this.
faceleg commentedon Mar 21, 2013
Fixed with c94c6a5.