Skip to content

unit tests broken in travis-ci #52

Closed

Description

@tbranyen

because travis-ci only fetches 100 commits and our unit test depends on an older one

Activity

  1. tbranyen commented on Mar 15, 2013

    @tbranyen
    MemberAuthor

    Fixed that problem with an undocumented Travis-CI feature I found here: https://twitter.com/travisci/status/288390896339267584

    Now we have a seg fault 👎

  2. faceleg commented on Mar 15, 2013

    @faceleg
    Collaborator

    @tbranyen I did wonder why that didn't work. I noticed the segfault too, I'll hopefully be able to address that tonight. I've been doing a bit of work on the C++ side, updated libgit2 to a recent development version (on advice from the libgit2 devs), and have been asynchronizing as much as I could. I also re-did error, as libgit2 changed the way they made errors.

  3. tbranyen commented on Mar 17, 2013

    @tbranyen
    MemberAuthor

    valgrind node ../node_modules/nodeunit/bin/nodeunit convenience-commit.js try this command @faceleg it's pumping out a ton of invalid read errors

  4. faceleg commented on Mar 17, 2013

    @faceleg
    Collaborator

    @tbranyen I am sure I'm doing a bunch of memory management improperly, and would love to fix it, but valgrind is telling me not to trust it on 10.8. I will have to dust off my ancient linux box for this.

  5. faceleg commented on Mar 21, 2013

    @faceleg
    Collaborator

    Fixed with c94c6a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions