Repository navigation
Generate Missing Tests - Unable #313
Description
Was looking at contributing to test coverage, and was following the guidelines for contributing in CONTRIBUTING.md. Found an issue with the file, in that it asks you to run npm run missing-tests to generate the missing tests. This doesn't work any more. Managed to track down how you generate missing tests (by running generate/index.js). This also runs some other generating code.
I'm happy to update the contributing.md file to mention that you need to run node generate/index.js, or update the package.json to have a generate command, and submit a pull request.
Let me know how to proceed, thanks.
Activity
johnhaley81 commentedon Dec 4, 2014
Hey! It looks like it got renamed to
generateMissingTestsand now also needs to runnpm run generateJson.Running
node generate/index.jswill do a full build of nodegit which you don't really need to find out what tests are missing so I'd like to not do that if possible since that can take like 2-3 minutes on a decent machine.If you want to open a PR and update the
package.jsonand theCONTRIBUTING.mdto work with the above I'll be happy to merge it in!maxkorp commentedon Dec 4, 2014
Actually, running generate/index.js should just take a second or two tops. It doesn't do any compilation. It will generate the C++ code which you don't need to view missing tests (although you'll need it anyways if you're planning on writing and running tests, to be fair), but that's super fast.
graycodes commentedon Dec 4, 2014
Cool, yeah the generate/index.js doesn't take long. Unfortunately because the main function in the generateMissingTests.js file is only exported and not run within that file, when you call
npm run generateMissingTests, nothing happens (it just evaluates the function). So, as part of this I can fix it so that this file runs its code, before passing the result to generate/index.js?johnhaley81 commentedon Dec 4, 2014
Yeah! That sounds great.
graycodes commentedon Dec 4, 2014
Cool, I'll get cracking.
maxkorp commentedon Dec 4, 2014
👍