Unable to get reference for HEAD #311

Activity

1. johnhaley81 commented on Dec 4, 2014

   

   johnhaley81

   on Dec 4, 2014

   Collaborator

   More actions

   That is very strange. Can you post the complete relevant code block please?

   On Thu, Dec 4, 2014, 4:55 AM Bas Biesheuvel notifications@github.com
   wrote:

   When I try to get the reference for 'HEAD' in version 0.2.3:

   repo.getReference('HEAD').then(function() {
   console.log('success');
   }, function() {
   console.log('error');
   });

   I do not see 'success' nor 'error'. It just doesn't do anything. If it
   fails, I would expect to see 'error'..

   —
   Reply to this email directly or view it on GitHub
   #311.
2. Athaphian commented on Dec 4, 2014

   

   Athaphian

   on Dec 4, 2014

   Author

   More actions

   This is my complete code, I only removed the directoryname for privacy concerns. Note that I do not see 'success' or 'error'. If I return _repository.getReference('HEAD') in stead of true, the done() is never called.

   var nodegit = require('nodegit'),
       path = require('path');
   var _repository;
   
   nodegit.Repository.open(path.resolve(__dirname, '../../dirnameobfuscated/.git')).then(function (repo) {
     _repository = repo;
     return nodegit.Remote.load(repo, "origin");
   })
     // Fetch remote
       .then(function (remote) {
         remote.connect(0);
         return remote.download();
       })
     .then(function() {
       _repository.getReference('HEAD').then(function() {
         console.log('success');
       }, function() {
         console.log('error');
       });
   
       return true;
     })
   
     // Done collecting results, call callback function
       .done(function () {
         console.log('done');
       });
3. johnhaley81 commented on Dec 4, 2014

   

   johnhaley81

   on Dec 4, 2014

   Collaborator

   More actions

   This is a bug inside of /lib/repository.js.

   I'm looking into it now. Hopefully a fix will be easy. For right now you can use _repository.head().
4. johnhaley81

   added a commit that references this issue on Dec 4, 2014

   Fix #311

   This issue will close once commit 68e73c2 is merged into the 'master' branch.

   68e73c2
5. johnhaley81 commented on Dec 4, 2014

   

   johnhaley81

   on Dec 4, 2014

   Collaborator

   More actions

   That PR should fix the issue. I'll merge it in today and we'll have to publish another version here soon. We have a decent amount of fixes in.
6. johnhaley81

   closed this as completedon Dec 4, 2014
7. johnhaley81

   added 2 commits that reference this issue on Dec 5, 2014

   Fix #311

   This issue will close once commit 8a96141 is merged into the 'master' branch.

   8a96141

   Merge pull request #312 from nodegit/fix-issue-311

   ...

   This issue will close once commit 630f5e7 is merged into the 'master' branch.

   630f5e7