Skip to content

We're using too many promise libraries #264

Closed

Description

@maxkorp

We're currently using promisify-node and Q, and talking about adding bluebird. We should probably take a few hours and move everything to one library (which we also need to talk about). I like the idea of bluebird, but that would break a lot of our apis by exposing the unpromisified version in place of the current promisified version, and adding those methods adjacent to the others.

Activity

  1. maxkorp commented on Nov 10, 2014

    @maxkorp
    CollaboratorAuthor

    Or, per @tbranyen's comment here: #260, we can use v8-promises. I'm gonna advocate for that, actually.

  2. johnhaley81 commented on Nov 11, 2014

    @johnhaley81
    Collaborator

    We finally decided on forking then/promise into our own repo at nodegit/promise so we should move to that.

  3. tbranyen commented on Nov 13, 2014

    @tbranyen
    Member

    Yup we're gonna use our fork of then/promise and maintain that along with the project. We'll convert anything incoming with Promise.cast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions