Repository navigation
nodegit installation falls back when Python install dir contains spaces #261
Description
Hi folks,
I found a weird behaviour in the install.js script in 0.1.4. When the Python install folder location path contains spaces, then the following parsing logic fails:
python = results[0].value || results[1].value;
So the python string will be something like "C:\Program ". Then the subsequent functions fail of course.
Another and more serious problem is that the error message is swallowed in:
.fail(function(message) {
console.info('[nodegit] Failed to build nodegit.');
console.info('[nodegit] Attempting to fallback on a prebuilt binary.');
...
})I can see that there were some major changes on master branch, I am just reporting this to watch out for this edge case also.
Activity
johnhaley81 commentedon Oct 31, 2014
Thanks for the bug report! I'm not able to repo that issue on Windows. Did you get a chance to try it on master instead of 0.1.4?
johnhaley81 commentedon Oct 31, 2014
This is great work. If you open a pull request we'll merge after the tests pass.
Can you not include the console change though?
johnhaley81 commentedon Nov 20, 2014
PR #280 should fix this issue. If you have any other problems with this feel free to re-open this issue.