example/convenience-repo.js errors #21

Activity

1. tbranyen commented on Apr 22, 2011

   

   tbranyen

   on Apr 22, 2011

   Member

   More actions

   Thanks for reporting this issue. I noticed this bug shortly after releasing 0.0.3 and it has been fixed in the 0.0.4 branch. I ran the convenience-repo.js and noticed I hadn't updated it to reflect the new event based lookup api.

   I've updated convenience-repo.js in the 0.0.4 branch and it is working fine for me. Can you do an upstream pull and checkout the 0.0.4 branch and test?
2. dodo commented on Apr 22, 2011

   

   dodo

   on Apr 22, 2011

   Author

   More actions

   one failure so far:

   […]
   raw-blob.js
   ✔ constructor
   ✖ lookup
   
   Assertion Message: Valid reference lookup
   AssertionError: 'Object does not exist in the scope searched.' == 0
       at Object.equals (nodegit/vendor/nodeunit/lib/types.js:81:39)
       at nodegit/test/raw-blob.js:70:12
   […]
   

   but convenience-repo.js works now …

   thank you very much.
3. tbranyen

   closed this as completedin 964f894on Apr 22, 2011
4. djui commented on May 6, 2011

   

   djui

   on May 6, 2011

   More actions

   I also got the same error when running the convenience-repo.js, then tried out to install the 0.0.4 branch, but get the following error:

   [10/13] cxx: src/revwalk.cc -> build/default/src/revwalk_1.o                                                             
   ../src/blob.cc: In static member function ‘static v8::Handle<v8::Value> GitBlob::CreateFromBuffer(const v8::Arguments&)’:
   ../src/blob.cc:226: error: ‘buffer’ was not declared in this scope                                                       
   ../src/blob.cc:227: error: expected primary-expression before ‘,’ token                                                  
   ../src/blob.cc:227: error: expected primary-expression before ‘)’ token                                                  
   Waf: Leaving directory `/Users/uwe/dev/nodegit/build'                                                                    
   Build failed:  -> task failed (err #1):                                                                                  
           {task: cxx blob.cc -> blob_1.o}                                                                                  
   make: *** [build] Error 1                                                                                                
   

   It looks like the code is not complete on line 227?
5. tbranyen commented on May 6, 2011

   

   tbranyen

   on May 6, 2011

   Member

   More actions

   Yup looks like I committed some broken code into that branch. I'll fix it up and let you know it when its all good.
6. tbranyen commented on May 8, 2011

   

   tbranyen

   on May 8, 2011

   Member

   More actions

   Hey djui I just pushed a fix that should take care of the issue in the 0.0.4 branch. Working today to solidify blob.cc
7. djui commented on May 9, 2011

   

   djui

   on May 9, 2011

   More actions

   Hej Tim,

   now it works fine for at least what I have tested.

   Btw: What is the "main" difference between your project and https://github.com/libgit2/node-gitteh/ ? At the moment I haven't grasp which progress level both projects are in...
8. tbranyen commented on May 9, 2011

   

   tbranyen

   on May 9, 2011

   Member

   More actions

   node-gitteh is samcday's project. He spent a lot of time stress testing and perfecting his backend, and he has significantly better coverage than nodegit does. We've talked a few times on merging projects, but the visions aren't quite the same. nodegit provides a 1:1 interface to libgit2 and then builds on top of that raw api with a pure JS convenience api. node-gitteh on the other hand does not provide a complete 1:1 interface and instead created a stylized api in C++ that is exposed to Node.

   nodegit is still very much a work in progress and without contributors its hard to map all 100+ functions. I've been working on all the significant ones, but again... takes time. If nodegit can't do what you want today, it's definitely work checking out node-gitteh.
9. djui commented on May 9, 2011

   

   djui

   on May 9, 2011

   More actions

   Thanks for the comparison!