Repository navigation
Can't install v0.1.2 under OSX #155
Description
0.1.2 build looks broken. Works fine with v0.1.1.
> nodegit@0.1.2 install /Users/benweet/workspace/stackedit-teamserver/node_modules/nodegit
> node install.js
[nodegit] Determining dependencies.
[nodegit] Removing vendor/libgit2.
[nodegit] Fetching vendor/libgit2.
[nodegit] Creating vendor/libgit2/build.
[nodegit] Configuring libgit2.
[nodegit] Failed to build nodegit.
Command failed: CMake Error: Could not create named generator Visual Studio 12 Win64
Error: Command failed: CMake Error: Could not create named generator Visual Studio 12 Win64
at ChildProcess.exithandler (child_process.js:637:15)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:743:16)
at Socket.<anonymous> (child_process.js:956:11)
at Socket.EventEmitter.emit (events.js:95:17)
` at Pipe.close (net.js:465:12)
Activity
[-]Can install v0.1.2 under OSX[/-][+]Can't install v0.1.2 under OSX[/+]tbranyen commentedon May 2, 2014
Well this is funny...
process.platform === "darwin"in OS X. I have awful code that doesindexOf("win")... patch forthcoming, thanks for reporting!tbranyen commentedon May 2, 2014
@benweet can you test: https://github.com/nodegit/nodegit/tree/hotfx-osx-support ? If it works I'll merge in and tag a 0.1.3 release.
benweet commentedon May 2, 2014
Works brilliantly.
tbranyen commentedon May 2, 2014
Thanks again, nodegit@0.1.3 published to NPM. Please reopen if you experience any issues.
benweet commentedon May 2, 2014
Thank you. Nice module by the way.