Add disable-password-checks option, Closes #983#998
Merged
kjetilk merged 1 commit intoDec 4, 2018
Merged
Conversation
5961ba1 to
f4dad83
Compare
megoth
approved these changes
Dec 3, 2018
megoth
left a comment
Contributor
There was a problem hiding this comment.
I'm more in favor of positive variants of variable-names that holds boolean, i.e. enablePasswordChecks, as double negatives such as !disablePasswordChecks is a bit more difficult to read.
That being said, this code looks good ^_^
Contributor
Author
|
@megoth I agree with you on that (I initially had However, I inverted it because I wanted to not make this a breaking change, and keep backwards compatibility with existing config files, where no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes development related to registration a lot more convenient,
and also allows users that do not need these strict checks to disable them.