Add pre-commit hook to trigger linter#964
Merged
Merged
Conversation
RubenVerborgh
approved these changes
Nov 23, 2018
RubenVerborgh
left a comment
Contributor
There was a problem hiding this comment.
Looks to me; just want to signal that https://www.npmjs.com/package/husky is the new kid on the block.
Member
|
Yeah, I like the idea, but I more like the idea of a pre-push hook to run |
Member
|
Now, we can reconsider this. Can you have a look, @jaxoncreed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time a commit is about to be done,
npm run standardwill be invoked.This makes standard-compliance a bit more convenient :-)
Even though this would be possible, the unit tests aren't executed during pre-commit because they take a bit too long to execute.