refactor: replace colors with colorette#812
Merged
Merged
Conversation
Colorette is lighter and faster than the colors package. It's also "safe" by default; it doesn't mutate the string prototype. Terminal color support is autodetected, so our console output will not contain unreadable symbols if the target terminal does not support color.
RubenVerborgh
approved these changes
Oct 1, 2018
Member
|
OK, so my knee-jerk reaction was to get it into the next 5.0.0 release, and that's why I set base to that. But that was just a knee-jerk reaction, no particular opinion here. :-) So, @RubenVerborgh you feel comfortable about merging it for a semver patch release that we do directly on |
Contributor
|
@kjetilk It should just be a minor thing, no strong opinion. |
Member
|
OK, great! Thanks a lot @jorgebucaran , you're in! :-) |
Contributor
Author
|
Thank you, @kjetilk & @RubenVerborgh! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hello maintainers.
Summary
This PR replaces colors with colorette. Disclaimer: I'm the author of colorette. This is a refactor change and does not intend to introduce breaking changes. Please let me know if this looks good or not and if you'd like me to make any changes.
Colorette is both lighter and faster than the colors packages. It's also "safe" by default, it doesn't mutate the string prototype. Terminal color support is autodetected, so our console output will not contain unreadable symbols if the target terminal does not support color.
Tests and coverage are at 100%.
Size Comparison
colorscoloretteRuntime Performance
All tests run on a 2.4GHz Intel Core i7 CPU with 16 GB memory. Complete benchmark results here and implementation here.