Send errors as plain text#804
Merged
Merged
Conversation
3c9e52c to
3071b12
Compare
kjetilk
reviewed
Sep 30, 2018
Member
kjetilk
left a comment
There was a problem hiding this comment.
OK, I see what it does, but that means, we always have plain text error messages? Nothing in the stack that can pass anything else?
Contributor
Author
|
@kjetilk Nothing in the stack should. If they do, we want to double check that anyway. |
Contributor
Author
|
That said, I haven't seen any code throw HTML errors (thankfully). |
kjetilk
approved these changes
Sep 30, 2018
Member
kjetilk
left a comment
There was a problem hiding this comment.
OK, good! I'll take it down on my whiteboard as something to review for 6.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.