Skip to content

Refactor solid init options, fix dataBrowserPath error#472

Merged
dmitrizagidulin merged 3 commits into
masterfrom
dz_fix_init_options
Dec 15, 2016
Merged

Refactor solid init options, fix dataBrowserPath error#472
dmitrizagidulin merged 3 commits into
masterfrom
dz_fix_init_options

Conversation

@dmitrizagidulin
Copy link
Copy Markdown
Contributor

@dmitrizagidulin dmitrizagidulin commented Dec 14, 2016

Fixes issue #465.
Also some refactoring of init options:

  • Move the 'mount' url question to earlier slot
  • Do not prompt user for various advanced options

@dmitrizagidulin
Refactor solid init options, fix dataBrowserPath error
9e75613 
Fixes issue #465.
Also some refactoring of init options:
- Move the 'mount' url question to earlier slot
- Do not prompt user for various advanced options
@dmitrizagidulin
Copy link
Copy Markdown
Contributor Author

dmitrizagidulin commented Dec 14, 2016

Tagging @dan-f / @nicola / @deiu for review.

@melvincarvalho
Copy link
Copy Markdown
Contributor

melvincarvalho commented Dec 14, 2016

I tried this a couple of times. First I got an error, where I think I may have typoed the path to my key:

Your branch is up-to-date with 'origin/dz_fix_init_options'.
nothing to commit, working directory clean
melvin@melvin-All-Series:/media/melvin/Data1/dev/node-solid-server$ node bin/solid init? Path to the folder you want to serve. Default is /media/melvin/Data1/dev/node-solid-server
? SSL port to run on. Default is 8443
? Enable WebID authentication Yes
? Serve Solid on URL path /
? Select authentication strategy WebID-TLS
? Path to the SSL private key in PEM format /home/.../privkey.pem
? Path to the SSL certificate key in PEM format /home/.../fullchain.pem


..node-solid-server/node_modules/rx/dist/rx.js:77
    throw e;
    ^
Nothing found at this path

Second time it worked

a couple of observations:

Neither of the above are show stoppers. Great improvement!

@dmitrizagidulin
Copy link
Copy Markdown
Contributor Author

dmitrizagidulin commented Dec 15, 2016

@melvincarvalho This latest commit should address both items you mentioned. Thanks!

@dmitrizagidulin dmitrizagidulin merged commit 05efea4 into master Dec 15, 2016
@dmitrizagidulin dmitrizagidulin deleted the dz_fix_init_options branch December 15, 2016 19:31
@dmitrizagidulin dmitrizagidulin mentioned this pull request Jan 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dan-f dan-f dan-f approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitrizagidulin @melvincarvalho @dan-f