Using 'url' to get the base URI for a resource#380
Conversation
|
Thanks @antoniogarrote! We'll take a look shortly. |
|
Hey @antoniogarrote nice to see you here :) I don't understand your example. Can you show me a valid and an invalid outcome? Paths are meant to be relative to the base ( |
'baseUrl' was returning the empty string, leading to a url for the resource matching the domain. This was causing an error in the JSON-LD serialization.
3b261df to
df70115
Compare
|
Hi @dmitrizagidulin, @nicola , thanks for your work on Solid. I have added a test to try to clarify the issue. Basically, I was always getting always only protocol+domain as the URI of the resource I was trying to fetch. So if the resource is 'https://domain/path/to/document#me', I was only getting 'https://domain#me' in the JSON-LD payload when I requested 'https://domain/path/to/document'. I tracked to the way the base uri was being generated in 'lib/utils.js' and the way it is passed to the JSON-LD library in the translation logic. I don't know much about express, so I hope it is not because of some kind of misconfiguration on my side. Thanks! |
|
Hey @antoniogarrote thanks a lot, I understand what is the problem now. (super thanks for your tests!) |
|
I didn't have time to go through this this week, will fix this soon |
|
Possibly related to #476 ? |
|
Closing this PR - the fix is being handled instead in PR #496. Thanks again to @antoniogarrote for bringing this to our attention. |
'baseUrl' was returning the empty string, leading to a url for the
resource always matching the domain.
This was causing an error in the JSON-LD serialization:
The change fixes the error and now it returns the right value for the '@id' property.