Skip to content

Fixing issues with proxy headers#257

Merged
deiu merged 6 commits into
masterfrom
fix-proxy-issues
Feb 23, 2016
Merged

Fixing issues with proxy headers#257
deiu merged 6 commits into
masterfrom
fix-proxy-issues

Conversation

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

Looks good so far, but I think it's still not proxying the Accept: header in the request (it passes along the response headers correctly)

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

NICE! Removing the connection: header fixed my proxy issue (it was passing Accept: correctly).

(I wonder why those CI tests failed.. they're passing for me locally)

@nicola

nicola commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

They pass on my machine

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

Force a push again, have CI re-run the tests?

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

Bumped Travis's node_js directive to 4.0 and 5.0, as discussed on gitter.

@nicola

nicola commented Feb 20, 2016

Copy link
Copy Markdown
Contributor Author

Tests still break, unfortunately I don't have time to look at this now, but it must be some slightly hidden trivial fix, maybe removing the cache on travis?

@nicola

nicola commented Feb 23, 2016

Copy link
Copy Markdown
Contributor Author

A clean install of ldnode actually does fail the test on my machine

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

@nicola - what OS?

@nicola

nicola commented Feb 23, 2016

Copy link
Copy Markdown
Contributor Author

@dmitrizagidulin Mac OS X, some of our dependencies must have updated their version (I guess nock does not serve the status code)

@nicola

nicola commented Feb 23, 2016

Copy link
Copy Markdown
Contributor Author

In fact, nock was not serving the status code, should be fixed in latest

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

Good good, now one of the builds succeeds :) (How do we get the other one to pass?)

@nicola

nicola commented Feb 23, 2016

Copy link
Copy Markdown
Contributor Author

I had to re-run one since travis some times loses connection when fetching databox for the webid used in ACL

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

You rock :)

deiu pushed a commit that referenced this pull request Feb 23, 2016
Fixing issues with proxy headers
@deiu deiu merged commit 8e31c31 into master Feb 23, 2016
@dmitrizagidulin dmitrizagidulin deleted the fix-proxy-issues branch February 23, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy dropping 'Location:' header

3 participants