Remove bootstrap dependency - #1874
Open
mmustafasenoglu wants to merge 1 commit into
Open
Conversation
Bootstrap 3.4.1 has known vulnerabilities and NSS only uses it for basic CSS layout. This replaces the entire dependency with a lightweight custom stylesheet. Closes nodeSolidServer#1867
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1867
Bootstrap 3.4.1 has known vulnerabilities and NSS only uses it for basic CSS layout (grid, panels, forms, buttons, alerts) plus a single glyphicon-remove icon. This replaces the entire dependency with a lightweight custom stylesheet.
Changes:
The glyphicon-remove icon is replaced with an inline SVG data URI, so no font files are needed either.
Tests pass (818 passing, 3 pre-existing EADDRINUSE failures).